Configure "delete account" button behavior#1339
Configure "delete account" button behavior#1339megastep wants to merge 3 commits intofirebase:mainfrom
Conversation
….swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to customize the account deletion button behavior in SignedInView via the AuthConfiguration. It adds a new DeleteAccountButtonAction enum allowing the button to be shown with a default confirmation sheet, hidden entirely, or linked to a custom action. Additionally, it includes UI updates to conditionally display the MFA management and delete account buttons, localizes strings in the deletion confirmation sheet, and adds corresponding unit tests and documentation. I have no feedback to provide.
|
Hey @megastep - This PR I'm not so sure on. The philosophy behind FirebaseUI Auth SwiftUI - the consumer should either accept the default Views or write their own custom Views, and this is customising the default Views. I'll have to get back to you on this once I've conferred with the team. |
2 participants
This makes the "Delete Account" button in the SignedInView configurable, for cases when the application needs more advanced account deletion configuration:
This also includes the changes from my previous PR #1338 to disable the MFA button if that is turned off in the project's configuration.
Also fixes some missing localized strings in the dialog, even though the strings were already localized.